Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make exists, found, not_found consistent #4480

Closed
clintongormley opened this issue Dec 17, 2013 · 4 comments
Closed

Make exists, found, not_found consistent #4480

clintongormley opened this issue Dec 17, 2013 · 4 comments
Assignees
@dakrone
Labels
>breaking v1.0.0.RC1

Comments

@clintongormley
Copy link

The GET and multi_get APIs return {"exists": true|false} while the DELETE and bulk delete APIs return {"found": true|false}, and the DeleteResponse class uses notFound.

All of these should be changed to use found, in order to make things more consistent.
@dadoonet
Copy link
Member

If we look at the discussion here: #4416 (comment)
We could think of having a status: 404 or status: 200?

WDYT?

@ghost ghost assigned dakrone Jan 2, 2014
@kimchy
Copy link
Member

kimchy commented Jan 2, 2014

I don't think we should do status here, the status is already returned in the response, and for the non error use case, its much nicer to be descriptive, yet in a consistent manner.

@kimchy
Copy link
Member

kimchy commented Jan 2, 2014

also, I would add that the index action should have a "created" flag in the rest response.

@dakrone dakrone mentioned this issue Jan 6, 2014
Closed
@dakrone
Copy link
Member

dakrone commented Jan 7, 2014

Merged in 2cb40fc

@dakrone dakrone closed this as completed Jan 7, 2014
karmi added a commit to elastic/elasticsearch-ruby that referenced this issue Jan 8, 2014
@karmi
[CLIENT] Remove the tests for "found"/"exists" in the integration test
3683048 
This change reflects the background-incompatible change from
elastic/elasticsearch#4480

Related: d540aa6
javanna added a commit that referenced this issue Jan 16, 2014
@javanna
[DOCS] updated json responses after #4310 and #4480
4126ae2 
 - Removed "ok": true from response examples
 - Added "created" flag to index response examples
 - Replaced exists flag with found in delete response examples
brusic pushed a commit to brusic/elasticsearch that referenced this issue Jan 19, 2014
@javanna @brusic
[DOCS] updated json responses after elastic#4310 and elastic#4480
017d958 
 - Removed "ok": true from response examples
 - Added "created" flag to index response examples
 - Replaced exists flag with found in delete response examples
@backnight backnight mentioned this issue Feb 17, 2014
Merged
picandocodigo pushed a commit to elastic/elastic-transport-ruby that referenced this issue Jun 7, 2021
@karmi
[CLIENT] Remove the tests for "found"/"exists" in the integration test
ae38a74 
This change reflects the background-incompatible change from
elastic/elasticsearch#4480

Related: d540aa6
renaperes824 added a commit to renaperes824/ruby-elastic-transport that referenced this issue Sep 12, 2022
@renaperes824
[CLIENT] Remove the tests for "found"/"exists" in the integration test
880b9a5 
This change reflects the background-incompatible change from
elastic/elasticsearch#4480

Related: d540aa6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dakrone dakrone

Labels
>breaking v1.0.0.RC1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename "exists" to "found" in TermVector and Get responses dakrone/elasticsearch
4 participants
@dakrone @kimchy @clintongormley @dadoonet